Return only one setting when setting_id is given (master) #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_settings GMP command will now only return the setting value that applies instead of both the user's and the global one.
mattmundell
approved these changes
Oct 9, 2019
| " AND " ACL_GLOBAL_OR_USER_OWNS () | ||
| /* Force the user's setting to come before the default. */ | ||
| " ORDER BY coalesce (owner, 0) DESC;", | ||
| " AND (owner = (SELECT id FROM users WHERE uuid = '%s')" |
There was a problem hiding this comment.
Would be nice to not do ACL stuff manually in here, but at least it's consistent with the other branch of the 'if'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_settings GMP command will now only return the setting value that
applies instead of both the user's and the global one.
Checklist: